kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.45k stars 1.49k forks source link

KEP-740: Update with decision on max token lifetime #4936

Closed HarshalNeelkamal closed 2 weeks ago

HarshalNeelkamal commented 3 weeks ago
- One-line PR description: Choice of max token lifetime was reconsidered during implementation. Documenting it accordingly.
k8s-ci-robot commented 3 weeks ago

Hi @HarshalNeelkamal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
HarshalNeelkamal commented 3 weeks ago

cc/ @liggitt

liggitt commented 2 weeks ago

/lgtm /approve

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HarshalNeelkamal, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[keps/sig-auth/OWNERS](https://github.com/kubernetes/enhancements/blob/master/keps/sig-auth/OWNERS)~~ [liggitt] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment