Open jm-franc opened 2 weeks ago
Welcome @jm-franc!
It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/enhancements has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @jm-franc. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Excellent work @jm-franc, thank you!
I left some suggestions in the comments, feel free to use them or tweak them further. I skipped the sections that are needed for Beta, since we're still a ways off (even the Alpha ones may be premature).
I think we can merge the end result as-is, and then work with the sig to get it to the
implementable
state.
Thank you for all those suggestions Patryk, I've merged all of them. I'm now sending this KEP for review.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jm-franc Once this PR has been reviewed and has the lgtm label, please assign gjtempleton for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/assign @gjtempleton
Assigning to Guy for review/approval.
Add KEP-4951: Configurable tolerance for HPA
Issue link: https://github.com/kubernetes/enhancements/issues/4951