search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.39k stars 1.46k forks source link

Add IPv4/IPv6 dual-stack support #563

Closed leblancd closed 2 years ago

leblancd commented 6 years ago

Feature Description

Corresponding kubernetes/kubernetes Issue: https://github.com/kubernetes/kubernetes/issues/62822

evillgenius75 commented 5 years ago

Hi @lachie83 @leblancd , I'm the 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

sftim commented 5 years ago

https://github.com/kubernetes/dns/issues/315 covers adding IPv6 / AAAA to the DNS service discovery specification.

kacole2 commented 5 years ago

@lachie83 @leblancd any idea if this will be graduating in 1.16 to track it?

lachie83 commented 5 years ago

@evillgenius75 @kacole2 This needs to be tracked in 1.16. This feature will be in alpha state. We will be implementing phase 1 and phase 2 as defined in the KEP is 1.16

Tracking KEP

Merged k/k PRs (currently in master will be in 1.16)

Associated PRs

simplytunde commented 5 years ago

Hey, @leblancd I'm the v1.16 docs release lead.

Does this enhancement (or the work planned for v1.16) require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday,August 23rd. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

lachie83 commented 5 years ago

@simplytunde here is the docs PR - https://github.com/kubernetes/website/pull/16010

kacole2 commented 5 years ago

@lachie83 friendly reminder code freeze for 1.16 is on Thursday 8/29. (as if you didn't know that). Looks like these PRs are still outstanding: Phase 2 Services/Endpoints - kubernetes/kubernetes#79386 Phase 2 kube-proxy - kubernetes/kubernetes#79576

Associated: Support multiple Mask Sizes for cluster cidrs - kubernetes/kubernetes#79993 E2e Prow Job for dualstack kubernetes/test-infra#12966

kacole2 commented 5 years ago

Hi @lachie83 @leblancd it looks as though https://github.com/kubernetes/kubernetes/pull/79576 and https://github.com/kubernetes/kubernetes/pull/79993 didn't merge before code freeze and it's not in the Tide Merge Pool. This feature is going to be bumped from v1.16. If you would still like to have this be a part of the 1.16 release, please file an exception

lachie83 commented 5 years ago

@kacole2 Apologies for the delays in response. The primary PR were were tracking was https://github.com/kubernetes/kubernetes/pull/79386. As for kubernetes/kubernetes#79576 we made a decision to defer that to 1.17 and instead focus on https://github.com/kubernetes/kubernetes/pull/82091 (in agreement with sig-network) which fulfills the same phase2 goals that were laid out in the KEP. The other related PR was tracked in this release was https://github.com/kubernetes/kubernetes/pull/80485 which is also merged. kubernetes/kubernetes#79993 has also been deferred to 1.17

mrbobbytables commented 4 years ago

Hey there @lachie83 @leblancd -- 1.17 Enhancements lead here. I wanted to check in and see if you think this Enhancement will be graduating to alpha/beta/stable in 1.17?

The current release schedule is:

If you do, please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

/milestone clear

lachie83 commented 4 years ago

Hi Bob. Thanks for reaching out. I'm still planning phase 3 of this enhancement which will round out the enhancement to completion. This enhancement will still be in alpha at the end of this release but there will be phase 3 related work that will land in k/k as part of 1.17.

lachie83 commented 4 years ago

Here is a list of high level deliverables for 1.17 for dual-stack. I will update this list throughout the release.

mrbobbytables commented 4 years ago

Much appreciated, thank you kindly @lachie83 ❤️ I'll go ahead and add it to the tracking sheet.

/milestone v1.17

lachie83 commented 4 years ago

@mrbobbytables I've also added a PR to detail the work listed above as part of phase 3 in the KEP after communicating the plan via sig-network. The KEP itself is still in the implementable state and these changes are merely documenting the planned work as part of 1.17 specifically.

sftim commented 4 years ago

At some point, I'd like to ensure that https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/ covers IPv6 DNS. https://github.com/kubernetes/website/issues/15434 tracks that change; mentioning it here to note a cross-reference.

lachie83 commented 4 years ago

Updated KEP to add phase 2 e2e tests - https://github.com/kubernetes/enhancements/pull/1311

irvifa commented 4 years ago

Hello @lachie83 I'm one of the v1.17 docs shadows. Does this enhancement for (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

irvifa commented 4 years ago

@lachie83

Since we're approaching Docs placeholder PR deadline on Nov 8th. Please try to get one in against k/website dev-1.17 branch.

mrbobbytables commented 4 years ago

Hey there @lachie83, I know you're keepin' tabs, but I need to pop in and mention it anyway 🙈 Code freeze is just around the corner (November 14th). How are things looking? Is everything on track to be merged before then?

Thanks!

lachie83 commented 4 years ago

Hey @mrbobbytables! Thanks for the ping. We are tracking the following PRs to land in 1.17. There may be one or two more PRs associated with this change that come in too. These changes will need docs. I will raise a placeholder docs PR

lachie83 commented 4 years ago

@irvifa - Here is the placeholder docs PR. https://github.com/kubernetes/website/pull/17457

irvifa commented 4 years ago

Cool thanks 🎉 @lachie83

mrbobbytables commented 4 years ago

@lachie83 tomorrow is the code freeze for the 1.17 release cycle. It looks like the k/k PRs have not yet been merged. 😬 We're flagging this as At Risk in the 1.17 Enhancement Tracking Sheet. Do you think they will be merged by the EoD of the 14th (Thursday)? After that point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

lachie83 commented 4 years ago

Thanks Bob - I'll be discussing this with sig-network today and will provide an update.

lachie83 commented 4 years ago

Hey @mrbobbytables. Here is a list of PRs that we are working on getting merged by EoD today and have been approved by sig-network.

The remaining PR is most likely going to be punted to 1.18 - https://github.com/kubernetes/kubernetes/pull/82462

lachie83 commented 4 years ago

@mrbobbytables just confirming that all stated PRs above have been merged and that we are indeed going to punt kubernetes/kubernetes#82462 to 1.18. This enhancement can still be tracked as these PRs add meaning changes to the dualstack behavior in 1.17. Now I just need to get the docs PR ready! We are hoping to land kubernetes/kubernetes#82462 in 1.18 and progress this work to beta

mrbobbytables commented 4 years ago

Great, thanks @lachie83!

CharlieTLe commented 4 years ago

And it's live! https://kubernetes.io/blog/2019/12/09/kubernetes-1-17-release-announcement/

lachie83 commented 4 years ago

We plan to move this enhancement to beta in 1.18. Enhancement graduation criteria and test plans can be found in the KEP along with this PR - https://github.com/kubernetes/enhancements/pull/1429

lachie83 commented 4 years ago

/milestone 1.18

k8s-ci-robot commented 4 years ago

@lachie83: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21]

Use /milestone clear to clear the milestone.

In response to [this](https://github.com/kubernetes/enhancements/issues/563#issuecomment-570321697): >/milestone 1.18 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
lachie83 commented 4 years ago

/milestone v1.18

jeremyrickard commented 4 years ago

We plan to move this enhancement to beta in 1.18. Enhancement graduation criteria and test plans can be found in the KEP along with this PR - #1429

Thanks for the update @lachie83, I've marked this as tracked in the 1.18 spreadsheet!

lachie83 commented 4 years ago

Please track the following PR as part of the work to land in 1.18. https://github.com/kubernetes/kubernetes/pull/82462

Adding other related PRs for tracking: https://github.com/kubernetes/test-infra/pull/15893 https://github.com/kubernetes-sigs/kind/pull/692

jeremyrickard commented 4 years ago

Thanks @lachie83!

palnabarun commented 4 years ago

Hi @lachie83, do you have any other PR's that we should track other than the above-mentioned ones?

sethmccombs commented 4 years ago

Hello, @lachie83 @leblancd - I'm a Docs shadow on the 1.18 release team.

Does this enhancement work planned for 1.18 require any new docs or modifications to existing docs?

If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If doc updates are required, reminder that the placeholder PRs against k/website (branch dev-1.18) are due by Friday, Feb 28th.

Let me know if you have any questions!

sftim commented 4 years ago

If anyone wants help documenting IPV6 or dual-stack stuff for v1.18, give me a nudge. I may be able to help.

jeremyrickard commented 4 years ago

Hey @lachie83,

Looks like kubernetes-sigs/kind#692 hasn't merged yet. Is that critical for your Beta graduation?

lachie83 commented 4 years ago

Hey @jeremyrickard @sethmccombs we're going to have to pull this from graduating to beta given this PR https://github.com/kubernetes/kubernetes/pull/86895. Until we have a reasonable way forward I don't think it is wise to move this to beta for 1.18

palnabarun commented 4 years ago

/milestone clear

palnabarun commented 4 years ago

@lachie83 Thank you for the update. I've removed this enhancement from the milestone. Looking forward to this on 1.19. :)

lachie83 commented 4 years ago

I would like to confirm that the state of the dualstack enhancement remains in alpha in 1.18. I am currently working with the community to assess the work planned to be completed in 1.19. It's likely this enhancement will still remain in alpha state in 1.19 however I would like to confirm. I will also take an action on getting the docs updated to reflect the enhancement state in the 1.18 docs.

sftim commented 4 years ago

If there are pages on the website that show dual-stack Kubernetes as beta, please file those against k/website as priority/important-soon bugs.

palnabarun commented 4 years ago

Hi @lachie83 -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate in 1.19?

The current release schedule is:

lachie83 commented 4 years ago

If there are pages on the website that show dual-stack Kubernetes as beta, please file those against k/website as priority/important-soon bugs.

@sftim I've raised two PRs to address the release labelling in 1.17 and 1.18

lachie83 commented 4 years ago

@palnabarun We are working to get the dualstack KEP updated in the 1.19 release timeframe however we don't currently think that we will be landing code changes in the 1.19 release. We have one blocking issue with the work that's already been done (thanks to having it in alpha state). The blocking issue is https://github.com/kubernetes/kubernetes/pull/86895. We plan to address that via the follow KEP update https://github.com/kubernetes/enhancements/pull/1679 but it's going to take time get consensus on the proposed change. At this stage the dualstack enhancement will remain in alpha state until we address this blocking issue with the current implementation. I will provide updates as things progress.

palnabarun commented 4 years ago

Thank you, Lachie for the updates. I appreciate all the efforts! :slightly_smiling_face:

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

Reamer commented 4 years ago

/remove-lifecycle stale