search

kubernetes / enhancements

Enhancements tracking repo for Kubernetes
Apache License 2.0
3.42k stars 1.47k forks source link

TTL after finish #592

Closed janetkuo closed 2 years ago

janetkuo commented 6 years ago

Feature Description

tnozicka commented 6 years ago

Design proposal link (community repo): https://goo.gl/YxtxTi

Does the google doc need to be moved to community repo?

tnozicka commented 6 years ago

Reviewers from multiple companies preferred

Happy to review as well and help fill in the diversity requirement here.

janetkuo commented 6 years ago

Thanks @tnozicka! Added you as reviewer

janetkuo commented 6 years ago

Updated link to KEP as well

zparnold commented 6 years ago

Hey there! @janetkuo I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

janetkuo commented 6 years ago

@zparnold I've opened the docs PR: https://github.com/kubernetes/website/pull/10064; it's still WIP

justaugustus commented 6 years ago

@janetkuo -- Any update on docs status for this feature? Are we still planning to land it for 1.12? At this point, code freeze is upon us, and docs are due on 9/7 (2 days). If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

janetkuo commented 6 years ago

@justaugustus yes we're landing it for 1.12. The docs is under review https://github.com/kubernetes/website/pull/10064

justaugustus commented 6 years ago

Thanks for the update, @janetkuo!

ameukam commented 6 years ago

Hi folks, Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to alpha/beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP.

kacole2 commented 6 years ago

@janetkuo following up from @ameukam's comment. Is there a plan for this to graduate to beta in 1.13?

janetkuo commented 6 years ago

There's currently no plan to graduate it to beta in 1.13.

kacole2 commented 6 years ago

/milestone clear

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 5 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 5 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/592#issuecomment-470779567): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
therc commented 5 years ago

What are the next steps for this? Will it require further changes or graduate to beta?

nwbvt commented 5 years ago

Does this need to be reopened to get moved out of alpha?

janetkuo commented 5 years ago

/reopen /remove-lifecycle rotten

k8s-ci-robot commented 5 years ago

@janetkuo: Reopened this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/592#issuecomment-507343073): >/reopen >/remove-lifecycle rotten Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
janetkuo commented 5 years ago

Our next steps is to implement this feature for Pods, as documented in KEP https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/0026-ttl-after-finish.md#api-object

Before going to beta, we need to decide whether to generalize it to custom resources, which may require moving the .ttlAfterFinished field from .spec to .metadata.

rbitia commented 5 years ago

Hi @janetkuo, I'm the 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If it's not graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

janetkuo commented 5 years ago

TTL controller currently supports Jobs, and we're adding support for Pods in 1.16 (covered in existing KEP already). The feature can only graduate to beta after that (i.e. post 1.16).

rbitia commented 5 years ago

We won't track this for 1.16 then. Thanks for the response!

annajung commented 5 years ago

Hello @janetkuo , 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?

 Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Please note that the KEP is missing test plan.

Thank you!

🔔Friendly Reminder

helayoty commented 4 years ago

Hey there @janetkuo -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to beta in 1.18 or having a major change in its current level?

The current release schedule is:

Tuesday, January 28th EOD PST - Enhancements Freeze Thursday, March 5th, EOD PST - Code Freeze Monday, March 16th - Docs must be completed and reviewed Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status.

The KEP must also have graduation criteria and a Test Plan defined.

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

helayoty commented 4 years ago

Hey @janetkuo -- 1.18 Enhancements team shadow here. We're about 5 days away from Enhancement Freeze on Jan 28th. Wanted to check to see if you'll be graduating this to beta in 1.18?

tahasabih commented 4 years ago

@janetkuo hey are there any plans to move this to beta? It was going at a good pace to be merged into beta but now seems it's been in limbo for a while :(

msedzins commented 4 years ago

Hey there @janetkuo -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

msedzins commented 4 years ago

Hi @janetkuo , kind reminder about my question above.

Thx!

msedzins commented 4 years ago

Hi @janetkuo , kind reminder about my question above.

Thx!

jqmichael commented 4 years ago

@janetkuo I would love to help out on some of the tasks to promote this feature to beta. Super critical to customers who run tons of jobs. Let me know.

msedzins commented 4 years ago

Hey @janetkuo , Enhancement shadow for the v1.19 release cycle here. Just following up on my earlier update to inform you of the upcoming Enhancement Freeze scheduled on Tuesday, May 19.

Regards, Mirek

palnabarun commented 4 years ago

@janetkuo -- Unfortunately the deadline for the 1.19 Enhancement freeze has passed. For now, this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

pre commented 4 years ago

This KEP is now 2 years old and the last response from the original author @janetkuo is from 1 year ago (12 Jul 2019).

It seems that the original author has moved to other adventures.

Is there any possibility someone else could take over?

janetkuo commented 4 years ago

Sorry for the delayed response. Based on the graduation criteria stated in the KEP, we'll implement the same functionality for Pods, and decide whether we want to generalize this to custom resources before moving this feature to Beta.

Here's the latest PR that implemented this functionality for Pod: https://github.com/kubernetes/kubernetes/pull/82082 However that PR isn't active anymore. Happy to help if anyone wants to take over that effort.

techwhizbang commented 4 years ago

Many of us would love to see this move forward. It looks like the other PR for adding this functionality to Pods simply needs to be rebased.

techwhizbang commented 4 years ago

I took a crack at rebasing kubernetes/kubernetes#82082 against master and there are quite a few files that need resolution and unfortunately I'm not well versed enough in how to properly deal with some of the binary .pb files nor am terribly familiar with the Kubernetes source code.

Hoping someone with the familiarity and the motivation can take this forward.

wojtek-t commented 4 years ago

@techwhizbang - all the pb and yaml files that gave conflicts are autogenerated; running make update would solve your problem

techwhizbang commented 4 years ago

@wojtek-t thanks for the tip!

I've rebased it with the help of performing the make update. Along the way it seems there was some additional code drift so I'm working on a couple compilation errors. I should have something ready soon.

techwhizbang commented 4 years ago

I've rebased, addressed the previous code review comments, and fixed some of compilation errors that resulted in code drift since the last time here:

https://github.com/kubernetes/kubernetes/pull/92055

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

palnabarun commented 4 years ago

/remove-lifecycle stale

kikisdeliveryservice commented 4 years ago

Hi @wojtek-t @janetkuo

Enhancements Lead here. Any plans for this to move to beta in 1.20?

Thanks, Kirsten

kikisdeliveryservice commented 4 years ago

Hi @wojtek-t @janetkuo

Following up: 1.20 Enhancements Freeze is October 6th. Could you let us know if you have any plans for 1.20? To be included in the milestone: The KEP must be merged in an implementable state (the linked KEP is provisional) The KEP must have test plans (missing) The KEP must have graduation criteria

Also the linked KEP is using an older format please see for ref https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

Thanks, Kirsten

otherguy commented 3 years ago

The 1.20 feature freeze has passed and this feature did not make it to beta.

Any chance for this to happen in 1.21?

ahg-g commented 3 years ago

/assign

I will update the KEP and try to move this to beta in 1.21

ahg-g commented 3 years ago

@kow3ns @janetkuo I am planning to reorganize the KEP to indicate that ttl after finish for pods is a future work that can be done under a different feature flag, and the current work will focus on graduating the feature for jobs only, what do you think?

janetkuo commented 3 years ago

No objections from me. We've seen requests for graduating this feature for Jobs, but haven't observed as many requests for expanding this feature for Pods or custom resources.

cc @tnozicka