API for external signing of Service Account tokens

micahhausler commented 5 years ago

Enhancement Description

One-line enhancement description (can be used as a release note): External signer integration for service account tokens
Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/740-service-account-external-signing
Primary contact (assignee): @ahmedtd
Responsible SIGs: sig-auth
Enhancement target (which target equals to which milestone):
- Alpha release target (x.y): 1.32
- Beta release target (x.y):
- Stable release target (x.y):
[ ] Alpha
- [x] KEP (k/enhancements) update PR(s): https://github.com/kubernetes/enhancements/pull/4852
- [ ] Code (k/k) update PR(s):
- [ ] Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

claurence commented 5 years ago

@micahhausler I see this issue has been added targeting Alpha for 1.14 - I'm the enhancements lead so if that is correct I'll add it to the milestone - as an FYI enhancements freeze is today 1/29 at PST EOD - we'll want to have a KEP for this issue merged and in an implementable state by then.

justaugustus commented 5 years ago

/assign @micahhausler

mrbobbytables commented 5 years ago

Hey there @micahhausler, I'm one of the 1.16 Enhancement Shadows. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If it's not graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

annajung commented 5 years ago

Hello @micahhausler, 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?   Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Please note that the KEP is missing test plan.

Thank you!

🔔Friendly Reminder

The current release schedule is
- Monday, September 23 - Release Cycle Begins
- Tuesday, October 15, EOD PST - Enhancements Freeze
- Thursday, November 14, EOD PST - Code Freeze
- Tuesday, November 19 - Docs must be completed and reviewed
- Monday, December 9 - Kubernetes 1.17.0 Released
A Kubernetes Enhancement Proposal (KEP) must meet the following criteria before Enhancement Freeze to be accepted into the release
- PR is merged in
- In an implementable state
- Include test plan and graduation criteria
All relevant k/k PRs should be listed in this issue

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

palnabarun commented 4 years ago

/remove-lifecycle stale

helayoty commented 4 years ago

Hey @micahhausler -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.18 or having a major change in its current level?

The current release schedule is:

Tuesday, January 28th EOD PST - Enhancements Freeze Thursday, March 5th, EOD PST - Code Freeze Monday, March 16th - Docs must be completed and reviewed Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status.

The KEP must also have graduation criteria and a Test Plan defined.

If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

micahhausler commented 4 years ago

@helayoty Yes this is planned for 1.18 in alpha

helayoty commented 4 years ago

Thank you @micahhausler for confirming. Please update the issue with the updated KEP and all PRs related.

helayoty commented 4 years ago

/milestone v1.18

palnabarun commented 4 years ago

Updated the issue description with the KEP link.

palnabarun commented 4 years ago

Hi @micahhausler, sorry for putting this at the last minute, but it seems like the KEP is missing both test plans and graduation criteria. They are required for this enhancement to be considered for this release.

Can you please update the KEP accordingly?

jeremyrickard commented 4 years ago

@micahhausler, unfortunately since this doesn't have test plans or graduation criteria, we are going to need to bump this from the 1.18 release. If you can update the KEP and file an Exception Request we can get it back in!

jeremyrickard commented 4 years ago

/milestone clear

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

palnabarun commented 4 years ago

/remove-lifecycle stale

palnabarun commented 4 years ago

Hi @micahhausler -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate in 1.19?

In order to have this part of the release:

The KEP PR must be merged in an implementable state
The KEP must have test plans
The KEP must have graduation criteria.

The current release schedule is:

Monday, April 13: Week 1 - Release cycle begins
Tuesday, May 19: Week 6 - Enhancements Freeze
Thursday, June 25: Week 11 - Code Freeze
Thursday, July 9: Week 14 - Docs must be completed and reviewed
Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

palnabarun commented 4 years ago

Hi @micahhausler, pinging back again as a reminder for the above.

palnabarun commented 4 years ago

Hi @micahhausler,

Tomorrow, Tuesday May 19 EOD Pacific Time is Enhancements Freeze

Will this enhancement be part of the 1.19 release cycle?

palnabarun commented 4 years ago

@micahhausler -- Unfortunately, the deadline for the 1.19 Enhancement freeze has passed. For now, this is being removed from the milestone and 1.19 tracking sheet. If there is a need to get this in, please file an enhancement exception.

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

palnabarun commented 4 years ago

/remove-lifecycle stale

kikisdeliveryservice commented 4 years ago

Hi @micahhausler

Enhancements Lead here. Are there any plans for this 1.20?

Thanks! Kirsten

kikisdeliveryservice commented 4 years ago

Hi @micahhausler

Following up: 1.20 Enhancements Freeze is October 6th. Could you let us know if you have plans for 1.20? To be included in the milestone: The KEP must be merged in an implementable state The KEP must have test plans (missing) The KEP must have graduation criteria (missing)

As a note, the format of KEPs has changed. If you could please update and include the missing sections noted above that would be great. See for ref https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template

Best, Kirsten

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 3 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community. /close

k8s-ci-robot commented 3 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes/enhancements/issues/740#issuecomment-782781469): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

jenshu commented 1 week ago

Hello @micahhausler 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting stage alpha for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

[ ] KEP readme using the latest template has been merged into the k/enhancements repo.
[ ] KEP status is marked as implementable for latest-milestone: v1.32.
[ ] KEP readme has up-to-date graduation criteria
[ ] KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we need a few things (I see that you have a PR currently open with some changes already):

[ ] Can you please make sure to fill out the Graduation Criteria
[ ] In your kep.yaml, the status should be set to implementable and the latest-milestone should be set to v1.32
[ ] You will also need to create a PRR that shows an approver for the alpha stage.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

soltysh commented 1 week ago

When updating the KEP, feel free to assign me the PRR approval.

enj commented 1 day ago

@jenshu #4852 is merged.

jenshu commented 13 hours ago

@liggitt @ahmedtd the KEP and PRR look good, I've updated the issue status to tracked for enhancements freeze!

kubernetes / enhancements

API for external signing of Service Account tokens #740

Enhancement Description