kubeadm: graduate the kubeadm configuration

[neolit123]

Enhancement Description

• One-line enhancement description (can be used as a release note):

Iterate on the kubeadm configuration (API) until it graduates to GA

• Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR) https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/kubeadm/970-kubeadm-config
• Primary contact (assignee): @neolit123
• Responsible SIGs: Cluster-Lifecycle
• Enhancement target (which target equals to which milestone):
  • Alpha release target PAST
  • Beta release target 1.22 (v1beta3)
  • Stable release target TODO

---

1.15

for the 1.15 cycle we want to upgrade the config type from v1beta1 to v1beta2. Umbrella issue for tracking this work: https://github.com/kubernetes/kubeadm/issues/1439

---

1.22

for the 1.22 cycle we want to upgrade the config type from v1beta2 to v1beta3. Umbrella issue for tracking this work: https://github.com/kubernetes/kubeadm/issues/1796

KEP updates:

• [x] https://github.com/kubernetes/enhancements/pull/2627

[k8s-ci-robot]

@neolit123: There are no sig labels on this issue. Please add a sig label.

A sig label can be added by either: 1. mentioning a sig: `@kubernetes/sig--` e.g., `@kubernetes/sig-contributor-experience-` to notify the contributor experience sig, OR 2. specifying the label manually: `/sig ` e.g., `/sig scalability` to apply the `sig/scalability` label Note: Method 1 will trigger an email to the group. See the [group list](https://git.k8s.io/community/sig-list.md). The `` in method 1 has to be replaced with one of these: _**bugs, feature-requests, pr-reviews, test-failures, proposals**_ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[rosti]

/assign

[rosti]

Thanks for creating the issue @neolit123 !

[neolit123]

@rosti updated the description and title.

[craiglpeters]

@fabriziopandini and @luxas, Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

[neolit123]

@craiglpeters thanks for the heads up. done: https://github.com/kubernetes/enhancements/blob/master/keps/sig-cluster-lifecycle/kubeadm/0023-kubeadm-config.md

[christianh814]

Hey @neolit123 and @rosti I'm the v1.15 docs shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Friday, May 31st. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[neolit123]

hi @christianh814 this work will require minor updates on already existing links to the godocs documentation of the kubeadm API. we are going to have the PRs up before the 31st.

thanks for the heads up.

[craiglpeters]

Hi @rosti. Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

[makoscafee]

Hi, @neolit123 I am docs Lead. Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must have placeholder docs PRs open. Just friendly following up on this. Thanks

[rosti]

Thanks for the reminder @makoscafee and @craiglpeters !

[rosti]

@craiglpeters kubernetes/kubernetes#77739 kubernetes/kubernetes#78403

@makoscafee kubernetes/website#14607

Those are the PRs.

[craiglpeters]

@rosti great to see the PRs have merged :)

[kacole2]

Hi @rosti @neolit123 , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.6 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[neolit123]

hi @kacole2. we decided that this feature will not see any changes with the release of 1.16. but we may still file a number of related WIP/POC KEPs.

[neolit123]

we will be tracking an update for 1.17 for a new release of the kubeadm configuration - v1beta3. updated OP.

[justaugustus]

@neolit123 -- As a heads up, the Enhancements team should be the only ones manipulating the tracked/* labels.

• tracked/yes: the Enhancements team has discussed with the owner and added the issue to the Enhancements tracking spreadsheet
• tracked/no: the Enhancements team has discussed with the owner and the enhancement will not be graduating for the cycle in question

Milestone maintainer rights should only be used to edit issue descriptions in k/enhancements. ref: https://github.com/kubernetes/enhancements/issues/590

[SataQiu]

/cc

[mrbobbytables]

It has been added to the tracking sheet for 1.17. 👍

[pgburt]

Hello @neolit123 , I'm one of the v1.17 docs shadows. Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so).

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

[neolit123]

@pgburt hi, most of the docs will be auto-generated godoc, but a single PR will be required to make minor updates to k/website pages.

November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

cc @rosti in case i cannot send this.

[pgburt]

Hi @neolit123 @rosti. Thanks for the note about the auto-generated godoc. Do you have a link for the single PR for the minor k/website updates? I'd love to get that linked to in the Enhancements Tracking sheet.

As a reminder, we're hoping to have placeholder PRs against kubernetes/website (branch dev-1.17) by Friday, Nov 8th. Cheers,

[jeremyrickard]

Hi @neolit123 @rosti,

Jeremy from the 1.17 enhancements team here 👋. We're closing in on Code Freeze on Nov 14th, so I wanted to check in and see how this was going and if you still think it will be landing in 1.17?

Thanks in advance!

[jeremyrickard]

Hey @rosti @neolit123, just checking in. We'll need a draft PR for docs for this by the end of the day in order to keep this issue in the 1.17 release. If there isn't a PR by the end of the day, we'll need to obtain an exception to keep this in 1.17

[neolit123]

@jeremyrickard hi, the placeholder PR for docs in 1.17 is here: https://github.com/kubernetes/website/pull/17500

[neolit123]

@jeremyrickard @pgburt we decided to drop the version increment of the kubeadm v1beta3 type for 1.17. feel free to remove tracked/yes for this cycle.

[jeremyrickard]

Got it @neolit123, thanks for the update.

[jeremyrickard]

/milestone clear

[jeremyrickard]

Hey @neolit123 👋 ,

Since this moved out of 1.17 I wanted to check and see if this will bumping to a new version in 1.18? Thanks!

[neolit123]

@jeremyrickard hi, we haven't decided yet. we will leave a comment on this issue once it is more clear.

[jeremyrickard]

Hey @neolit123,

Any update on this for 1.18? Enhancement freeze is right around the corner.

[neolit123]

hi, we are not going to add a new API version as part of 1.18.

[fejta-bot]

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

[neolit123]

/remove-lifecycle stale

[BenTheElder]

/remove-lifecycle stale

[harshanarayana]

Hey there @rosti -- 1.19 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating in 1.19?

In order to have this part of the release:

1. The KEP PR must be merged in an implementable state
2. The KEP must have test plans
3. The KEP must have graduation criteria.

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

If you do, I'll add it to the 1.19 tracking sheet (http://bit.ly/k8s-1-19-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

[neolit123]

hi, we are not going to add a new API version as part of 1.19.

[harshanarayana]

Hey @neolit123, thanks for following up on this with an update. I have update the tracking sheet accordingly. 🖖

Thanks

[fejta-bot]

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

[neolit123]

/remove-lifecycle stale

[kikisdeliveryservice]

Hi @neolit123

Enhancements Lead here. Any plans for this in 1.20?

Thanks! Kirsten

[neolit123]

Hi. Not for now, but will update you if we change our plans for 1.20.

[fejta-bot]

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

[neolit123]

/remove-lifecycle stale

[fejta-bot]

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

[pacoxu]

Link changed to https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/kubeadm/970-kubeadm-config

[neolit123]

/milestone v1.22 for tracking

[jrsapi]

Greetings @neolit123! 1.22 Enhancement shadow checking in. The Enhancement freeze is this Thursday, 5/13. In reviewing your KEP, one item needing attention before the freeze:

• (PRR) Production readiness review needs to be approved. #prod-readiness channel on K8s slack can assist.

Thanks!

[neolit123]

@jrsapi hello, the kubeadm API predates the PRR process. it was never done for it and is arguably not needed. based on recent discussions, PRR was partially a no-op for another kubeadm KEP: https://github.com/kubernetes/enhancements/pull/2620#issuecomment-828797098

i think the PRR process needs to be scoped more clearly and potentially be only mandatory for core functionality or opt-in for out-of-core.

[jrsapi]

Thanks for the link to the comment. I'll move the to "Tracked" in the Enhancement spreadsheet.