kubernetes / examples

Kubernetes application example tutorials
Apache License 2.0
6.16k stars 4.52k forks source link

Update selenium example to selenium 4.0 #425

Closed rueyaa332266 closed 2 years ago

rueyaa332266 commented 2 years ago

The newest major version of Selenium 4.0 was released, and some specifications had been changed. Updating the example to follow the latest version. Also fix some out-of-date procedures in the example’s README.

These changes are follow in the latest Selenium README: https://github.com/SeleniumHQ/docker-selenium

k8s-ci-robot commented 2 years ago

Welcome @rueyaa332266!

It looks like this is your first PR to kubernetes/examples 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/examples has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

rueyaa332266 commented 2 years ago

/assign @sebgoa

idvoretskyi commented 2 years ago

Thanks @rueyaa332266!

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: idvoretskyi, rueyaa332266

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/examples/blob/master/OWNERS)~~ [idvoretskyi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment