search

kubernetes / examples

Kubernetes application example tutorials
Apache License 2.0
6.21k stars 4.54k forks source link

Docker image has not been updated to reflect host name change (redis-slave -> redis-replica) #437

Closed warrensbox closed 2 years ago

warrensbox commented 2 years ago

In main.go, on line 70, redis-slave:6379 was refactored to redis-replica:6379 on Aug 12, 2021. See: https://github.com/kubernetes/examples/commit/69f7ab04f877ebf9988d33a8b13426a74d9348b3#diff-4db2d0a3cc62848825f64d1ac729ca2fd43579736f02c55b8a5bdac93220ebfe

However, the docker image hasn't been updated to reflect this change. The last time the image was updated was 4 years ago, on Dec 22, 2017. (See guestbook-controller.json - line 25) https://github.com/kubernetes/examples/commit/40f5426f1ed1ada18b3e35407017f687c0e3dd64#diff-7e942bc4b4d9b4efdd1861b88c63b3692a8b24ec491c38256843632aa2e93f09

As a result, the application still looks for the old host name which is redis-slave. 

PANIC: dial tcp: lookup redis-slave on 10.100.0.10:53: no such host
goroutine 54 [running]:

Suggested fix: docker build the updated go file and update the tag to v4.

Others here who are facing this issue, please feel free to use my docker image warrensbox/guestbook:v4 until this is fixed.

Temporary fix ( guestbook-controller.json - line 25) Change to line 25 TO "image":"warrensbox/guestbook:v4"

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

patrocinio commented 2 years ago

This problem seems to have been fixed, as I see the code at https://github.com/kubernetes/examples/blob/master/guestbook-go/main.go#L79 as redis-replica

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 2 years ago

@k8s-triage-robot: Closing this issue.

In response to [this](https://github.com/kubernetes/examples/issues/437#issuecomment-1186560366): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.