search

kubernetes / examples

Kubernetes application example tutorials
Apache License 2.0
6.16k stars 4.52k forks source link

issue #506--->fixed the redis issue #524

Closed bansalji02 closed 4 months ago

bansalji02 commented 4 months ago

While creating docker image of guestbook go, We encountered an error regarding the simpleredis reposity. Modified and changed it to the v2 of repo. The DockerImage is created successfully now. Also changes the redis image in redis master controller and replica controller yaml file. The issue should have been resolved

linux-foundation-easycla[bot] commented 4 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 4 months ago

Welcome @bansalji02!

It looks like this is your first PR to kubernetes/examples 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/examples has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

bansalji02 commented 4 months ago

/assign idvoretskyi

bansalji02 commented 4 months ago

/lgtm

k8s-ci-robot commented 4 months ago

@bansalji02: you cannot LGTM your own PR.

In response to [this](https://github.com/kubernetes/examples/pull/524#issuecomment-2119848005): >/lgtm > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
bansalji02 commented 4 months ago

@idvoretskyi , but it is not working and giving error in pulling image

idvoretskyi commented 4 months ago

@idvoretskyi , but it is not working and giving error in pulling image

@bansalji02 see the inline comment above, it works for me.

bansalji02 commented 4 months ago

Okay Thanks!

idvoretskyi commented 4 months ago

@bansalji02 no need to close this, other updates in your PR are valid :)

Just no need to fix that one that I've mentioned.

bansalji02 commented 4 months ago

@idvoretskyi changed it. Please review and approve. Thanks!

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bansalji02, idvoretskyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/examples/blob/master/OWNERS)~~ [idvoretskyi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment