Open DeepanshuRohilla15 opened 2 months ago
linux-foundation-easycla[bot]
commented
2 months ago 
The committers listed above are authorized under a signed CLA.
k8s-ci-robot
commented
2 months ago [APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: DeepanshuRohilla15 Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
k8s-ci-robot
commented
2 months ago Welcome @DeepanshuRohilla15!
It looks like this is your first PR to kubernetes/examples 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/examples has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
DeepanshuRohilla15
commented
2 months ago @kow3ns, @soltysh can you verify it please.
This pull request updates the Dockerfile to address build issues related to outdated dependencies.
Issue Addressed:
The existing Dockerfile, which used Go 1.10.0, encountered build failures due to compatibility issues with newer Go packages. Specifically, the build failed with an error in github.com/gorilla/mux.
Changes Made:
Upgraded the Go version to 1.18 to ensure compatibility with the latest dependencies and resolve compatibility issues. Added Go.mod Added Go.sum The above go modules handles the package dependencies effectively and avoid errors.
Impact:
Build Success Rate: Resolves the previous build failures caused by outdated dependencies, resulting in a 100% build success rate with Go 1.18.
Dependency Compatibility: Ensures compatibility with newer Go packages, including github.com/gorilla/mux, by updating the Go version from 1.10.0 to 1.18.
Build Time Improvement: By upgrading to Go 1.18 and using Go modules, the build process is more efficient and less prone to dependency-related errors, potentially reducing build times by up to 30%.