search

kubernetes / git-sync

A sidecar app which clones a git repo and keeps it in sync with the upstream.
Apache License 2.0
2.22k stars 411 forks source link

Update to use bookworm base image #764

Closed thockin closed 1 year ago

thockin commented 1 year ago

This include symlinks from /bin -> /usr/bin (and lib, and ...), which broke the build script. See comments in there for details.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/git-sync/blob/master/OWNERS)~~ [thockin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
thockin commented 1 year ago

Hmm, unexpected e2e fails.

thockin commented 1 year ago

Harumph, this expects /bin to be a symlink, but distroless has a real dir there, resulting in a collision. Not sure how to fix it. Will have to think.

thockin commented 1 year ago

Passes e2e now, final image size is 65.8 MB. Far too manual, but <shrug>