search

kubernetes / git-sync

A sidecar app which clones a git repo and keeps it in sync with the upstream.
Apache License 2.0
2.16k stars 409 forks source link

Make relative-path submodules work, via origin #765

Closed thockin closed 1 year ago

thockin commented 1 year ago

The "origin" remote is implicitly used as the basis for relative-paths in submodules. It's very subtly documented, and I have no idea if there are other places where it is used. It seems git really expects it to exist, so let's just do that.

Fixes #763

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/git-sync/blob/master/OWNERS)~~ [thockin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
thockin commented 1 year ago

Justin pointed out by chat that the set-url logic will not be run because the "normal" success path does early return. Easy fix, running e2e now

thockin commented 1 year ago

PTAL :)

justinsb commented 1 year ago

Thanks @thockin :-)

/lgtm