search

kubernetes / git-sync

A sidecar app which clones a git repo and keeps it in sync with the upstream.
Apache License 2.0
2.16k stars 409 forks source link

fix: handle errors from credential refresh #775

Closed karlkfi closed 11 months ago

karlkfi commented 12 months ago

Previously, errors from askpass and credential storage were being ignored, causing git clone/fetch to later error with hard-to-read errors.

Backport of https://github.com/kubernetes/git-sync/pull/774

k8s-ci-robot commented 12 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: karlkfi Once this PR has been reviewed and has the lgtm label, please assign nan-yu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/git-sync/blob/release-3.x/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment