search

kubernetes / git-sync

A sidecar app which clones a git repo and keeps it in sync with the upstream.
Apache License 2.0
2.22k stars 411 forks source link

Add linters to makefile/github actions #787

Closed justinsb closed 1 year ago

justinsb commented 1 year ago

Builds on #786, adds a linter task to the makefile and a task to the github actions CI.

I think if we merge #786, then this will run in github actions CI.

Issue #777

justinsb commented 1 year ago

Note this won't pass yet, because we need to fix the issues (hence the stream of small PRs).

/hold

thockin commented 1 year ago

786 merged

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/git-sync/blob/master/OWNERS)~~ [thockin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment