search

kubernetes / git-sync

A sidecar app which clones a git repo and keeps it in sync with the upstream.
Apache License 2.0
2.16k stars 409 forks source link

Rename github build workflow #791

Closed thockin closed 11 months ago

thockin commented 11 months ago

It says amd64, but calls all-build

justinsb commented 11 months ago

Good catch & I really like this. There's a choice in how we name the github actions "jobs", and I have previously proposed mapping them 1:1 to scripts under (for example) dev/ci - with the intention that then it becomes easy to run locally when needed. But if we're using make it makes a lot more sense to align them with the make targets.

(We might want to consider naming the thing which calls make all-build -> all-build, therefore, but now I'm just nit-picking)

/approve /lgtm

k8s-ci-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/git-sync/blob/master/OWNERS)~~ [thockin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment