Fix errors when parsing --repo for logging

kubernetes / git-sync

A sidecar app which clones a git repo and keeps it in sync with the upstream.

Apache License 2.0

2.14k stars 409 forks source link

Fix errors when parsing --repo for logging #830

Closed thockin closed 8 months ago

thockin commented 8 months ago

Only redact the URL password if it was actually provided.

If --repo is not a valid URL (e.g. user@host:path is a valid repo, but not a URL) , it's not an error, just log it.

Fixes #826

k8s-ci-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/git-sync/blob/master/OWNERS)~~ [thockin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment