search

kubernetes / git-sync

A sidecar app which clones a git repo and keeps it in sync with the upstream.
Apache License 2.0
2.22k stars 411 forks source link

fix(auth): Fix ssh authentication #868

Closed yyvess closed 6 months ago

yyvess commented 6 months ago

Ssh authentification

Fix ssh authentification break by https://github.com/kubernetes/git-sync/commit/d5c61f7ad19dea6ae6938dcb5dea7daa0b54676b

User must not be extracted from ssh as ssh://git@github.com/kubernetes/git-sync.git

linux-foundation-easycla[bot] commented 6 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 6 months ago

Welcome @yyvess!

It looks like this is your first PR to kubernetes/git-sync 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/git-sync has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

thockin commented 6 months ago

Oof, I need a CLA signed in order to merge this. Otherwise I can recreate it along with the e2e test (if you can't sign CLA).

/approve /lgtm

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, yyvess

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/git-sync/blob/master/OWNERS)~~ [thockin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yyvess commented 6 months ago

@thockin sign CLA

thockin commented 6 months ago

/lgtm