search

kubernetes / git-sync

A sidecar app which clones a git repo and keeps it in sync with the upstream.
Apache License 2.0
2.13k stars 406 forks source link

Fix: Use hugo mod get #874

Closed mattn closed 3 weeks ago

mattn commented 2 months ago

Recently hugo does not support hugoThemes and some themes are already missing. In the latest hugo, themes are treated as modules. So this change fixes that themes are retrieved in realtime with hugo mod get.

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mattn Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/git-sync/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 2 months ago

Welcome @mattn!

It looks like this is your first PR to kubernetes/git-sync 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/git-sync has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

mattn commented 1 month ago

Since hugo nowadays uses hugo mod get, it is no longer possible to bundle all themes as before. The theme list is already not complete and deprecated.

thockin commented 3 weeks ago

I was staring at this and I realized I really have no desire to maintain a hugo blog (hence why this has been broken so long).

I am putting up #889 instead. I appreciate the work on this, but I'm going to decline for now.