Add the idea of "env-flags"

kubernetes / git-sync

A sidecar app which clones a git repo and keeps it in sync with the upstream.

Apache License 2.0

2.13k stars 406 forks source link

Add the idea of "env-flags" #886

Closed thockin closed 3 weeks ago

thockin commented 3 weeks ago

Env-flags are flags that can only be set by env var. All of the real flags have a corresponding env-flag, kind of. The real goal was to deprecate --password but keep the env var as a documented interface.

This does that (though --password still works) and updates the usage and manual.

This allows some future work to follow the pattern.

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/git-sync/blob/master/OWNERS)~~ [thockin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment