Fix new github actions e2e failure

kubernetes / git-sync

A sidecar app which clones a git repo and keeps it in sync with the upstream.

Apache License 2.0

2.13k stars 406 forks source link

Fix new github actions e2e failure #890

Closed thockin closed 3 weeks ago

thockin commented 3 weeks ago

Tests worked 4 days ago, no committed changes since then. Now fails with:

testcase webhook_fail_retry: FAIL

docker: Error response from daemon: invalid config for network bridge: invalid endpoint settings:
user specified IP address is supported on user defined networks only.
See 'docker run --help'.

We have exactly one testcase that needs this (docker run --ip). It used to work and now it doesn't. It looks like maybe --ip NEVER worked but just didn't error before.

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/git-sync/blob/master/OWNERS)~~ [thockin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment