search

kubernetes / git-sync

A sidecar app which clones a git repo and keeps it in sync with the upstream.
Apache License 2.0
2.13k stars 406 forks source link

TODO: shellcheck test_e2e.sh and test_git.sh #891

Closed thockin closed 6 days ago

thockin commented 3 weeks ago

Its kind of a mess

rul commented 2 weeks ago

I'd like to give this a try. :slightly_smiling_face:

/assign

thockin commented 2 weeks ago

If you do this, a series of small PRs or at least small commits, each tackling one specific pattern of fix, please :)

On Tue, Jun 18, 2024 at 8:23 AM Raúl Benencia @.***> wrote:

I'd like to give this a try. 🙂

/assign

— Reply to this email directly, view it on GitHub https://github.com/kubernetes/git-sync/issues/891#issuecomment-2176374766, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKWAVFHAPDDRAWQHY6DWATZIBGHVAVCNFSM6AAAAABJI7AIIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZWGM3TINZWGY . You are receiving this because you authored the thread.Message ID: <kubernetes/git-sync/issues/891/2176374766 @.***>

thockin commented 1 week ago

Retitled to reference test_git.sh :)

thockin commented 1 week ago

test_e2e.sh is done - now for test_git.sh ?

rul commented 1 week ago

test_e2e.sh is done - now for test_git.sh ?

Yup! Will put up a PR soon.