search

kubernetes / git-sync

A sidecar app which clones a git repo and keeps it in sync with the upstream.
Apache License 2.0
2.13k stars 406 forks source link

test_e2e.sh: shellcheck entire file #902

Closed rul closed 1 week ago

rul commented 1 week ago

This contribution shellchecks the whole test_e2e.sh file. Check individual commits for more details. I've ran make test and verified that all tests still pass. Part of #891.

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rul Once this PR has been reviewed and has the lgtm label, please assign nan-yu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/git-sync/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
thockin commented 1 week ago

just a couple picks

thockin commented 1 week ago

Another pass might be to use local for all variables defined inside functions and to convert them all to common name style (lowercase for locals)

rul commented 1 week ago

Another pass might be to use local for all variables defined inside functions and to convert them all to common name style (lowercase for locals)

Makes sense. I think it's a bit out of scope for #801, so I've created #903.