kubernetes / git-sync

A sidecar app which clones a git repo and keeps it in sync with the upstream.
Apache License 2.0
2.13k stars 406 forks source link

test_git.sh: shellcheck entire file #905

Closed rul closed 6 days ago

rul commented 6 days ago

This contribution shellchecks the whole test_git.sh file. Check individual commits for more details. I've ran test_git.sh, and verified that all tests still pass.

Fixes https://github.com/kubernetes/git-sync/issues/891.

thockin commented 6 days ago

Thanks!
/lgtm /approve

k8s-ci-robot commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rul, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/git-sync/blob/master/OWNERS)~~ [thockin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment