kubernetes / ingress-gce

Ingress controller for Google Cloud
Apache License 2.0
1.27k stars 302 forks source link

OpenAPI v2 schema not published for BackendConfig #1055

Closed jpbetz closed 4 years ago

jpbetz commented 4 years ago

BackendConfig CRDs are non-structural because they do not have pruning enabled (note in the CRD thatpreserveUnknownFields: true). See https://v1-17.docs.kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/#publish-validation-schema-in-openapi-v2.

How to reproduce:

Pruning can be manually enabled by setting preserveUnknownFields: false in the BackendConfig CRD. Once enabled, /openapi/v2 returns the full schema.

I don't see any reason why pruning needs to be disabled for BackendConfig. It might be worth upgrading to the CRD v1 API at the same time?

rramkumar1 commented 4 years ago

@skmatti

skmatti commented 4 years ago

/assign @skmatti