search

kubernetes / ingress-gce

Ingress controller for Google Cloud
Apache License 2.0
1.27k stars 299 forks source link

Refactor EnsureL4BackendService to use params struct as an argument #2557

Closed cezarygerard closed 4 months ago

cezarygerard commented 4 months ago

Instead of lengthy list of args

cezarygerard commented 4 months ago

/assign @felipeyepez /assign @mmamczur /assign @code-elinka /assign @swetharepakula

k8s-ci-robot commented 4 months ago

@cezarygerard: GitHub didn't allow me to assign the following users: felipeyepez.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes/ingress-gce/pull/2557#issuecomment-2122722838): >/assign @felipeyepez >/assign @mmamczur >/assign @code-elinka >/assign @swetharepakula Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
code-elinka commented 4 months ago

/approve lgtm

mmamczur commented 4 months ago

/lgtm

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cezarygerard, code-elinka, mmamczur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/ingress-gce/blob/master/OWNERS)~~ [cezarygerard,code-elinka,mmamczur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment