search

kubernetes / ingress-gce

Ingress controller for Google Cloud
Apache License 2.0
1.27k stars 299 forks source link

Switch to CRDs from gke-networking-api. #2598

Closed yswe closed 2 months ago

yswe commented 3 months ago

Fixes #2597

Update due to these CRDs have been moved from k8s.io/google-cloud-provider/crd to github.com/GoogleCloudPlatform/gke-networking-api.

Tested: make build && make test

linux-foundation-easycla[bot] commented 3 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 3 months ago

Welcome @yswe!

It looks like this is your first PR to kubernetes/ingress-gce 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-gce has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 3 months ago

Hi @yswe. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
aojea commented 3 months ago

/ok-to-test

sawsa307 commented 3 months ago

This change looks good to me. I'll leave the approve label to @swetharepakula @cezarygerard since it is not an urgent change.

sawsa307 commented 3 months ago

/lgtm

sawsa307 commented 3 months ago

Could you also add "Fixes #2597" in the PR description?

yswe commented 3 months ago

/assign kl52752

swetharepakula commented 2 months ago

/assign @swetharepakula

swetharepakula commented 2 months ago

The change LGTM, do you mind splitting the vendor changes into its own commit (same PR)?

yswe commented 2 months ago

@swetharepakula ,

The change LGTM, do you mind splitting the vendor changes into its own commit (same PR)?

Done:

Switch to gke-networking-api CRDs.

Switch to gke-networking-api CRDs: vendor changes.

cezarygerard commented 2 months ago

Don't want to be picky by please give more elaborate commit message

etc

other than that its LGTM

yswe commented 2 months ago

Done. New commits with updated descriptions.

Switch to gke-networking-api CRDs.

Switch to gke-networking-api CRDs: vendor changes.

swetharepakula commented 2 months ago

/lgtm /approve

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sawsa307, swetharepakula, yswe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/ingress-gce/blob/master/OWNERS)~~ [swetharepakula] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment