search

kubernetes / ingress-gce

Ingress controller for Google Cloud
Apache License 2.0
1.27k stars 301 forks source link

Add backend_type label to l4_netlbs_count and the L4_netlb latency metrics #2691

Closed mmamczur closed 1 month ago

mmamczur commented 1 month ago

This extends the L4 NetLB metrics with backend_type field that will allow tracking the adoption and performance of NEG backed LBs vs IG ones.

mmamczur commented 1 month ago

/assign @swetharepakula

mmamczur commented 1 month ago

/hold need to make sure to update monarch schema with the new field before merging

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmamczur, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/ingress-gce/blob/master/OWNERS)~~ [mmamczur,swetharepakula] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mmamczur commented 1 month ago

/unhold