Update k8s.io/cloud-provider-gcp/providers with the latest commit

kubernetes / ingress-gce

Ingress controller for Google Cloud

Apache License 2.0

1.27k stars 301 forks source link

Update k8s.io/cloud-provider-gcp/providers with the latest commit #2693

Closed panslava closed 1 month ago

panslava commented 1 month ago

Commands ran:

go get k8s.io/cloud-provider-gcp/providers@c2d05af3b14f885e2560139dd6fb4581ceb01733
go mod tidy
go mod vendor
./hack/update-codegen.sh

/assign @gauravkghildiyal @swetharepakula

gauravkghildiyal commented 1 month ago

It's possible the changes in ./hack are not intentional? Can you double check?

panslava commented 1 month ago

my mistake... removed hack changes

panslava commented 1 month ago

Need to update composite types, working on that

panslava commented 1 month ago

should be done now, waiting for tests to pass

panslava commented 1 month ago

/retest

gauravkghildiyal commented 1 month ago

Thanks!

/lgtm

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, panslava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/ingress-gce/blob/master/OWNERS)~~ [gauravkghildiyal,panslava] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment