search

kubernetes / ingress-gce

Ingress controller for Google Cloud
Apache License 2.0
1.27k stars 301 forks source link

[Cherry-pick #2652 -> 1.31] Use default LocalityLBPolicy for ILB #2696

Closed FelipeYepez closed 1 month ago

FelipeYepez commented 1 month ago

LocalityLBPolicy = MAGLEV requires allowlisting. Implement logic to make ILBs use default "" LocalityLBPolicy and use MAGLEV once WEIGHTED_MAGLEV or MAGLEV is used.

k8s-ci-robot commented 1 month ago

Hi @FelipeYepez. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
FelipeYepez commented 1 month ago

/assign @mmamczur

mmamczur commented 1 month ago

/lgtm

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FelipeYepez, mmamczur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/ingress-gce/blob/release-1.31/OWNERS)~~ [mmamczur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment