Create additional NEGs based on subnets in Node Topology CR.

kubernetes / ingress-gce

Ingress controller for Google Cloud

Apache License 2.0

1.27k stars 301 forks source link

Create additional NEGs based on subnets in Node Topology CR. #2702

Open sawsa307 opened 4 weeks ago

sawsa307 commented 4 weeks ago

Query Node Topology CR for the current set of NEGs in the cluster.
When ensureNetworkEndpointGroups(), ensure NEGs are properly provisioned in the non-default subnets as well.

sawsa307 commented 3 weeks ago

/assign @gauravkghildiyal

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sawsa307 Once this PR has been reviewed and has the lgtm label, please ask for approval from gauravkghildiyal. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/ingress-gce/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

sawsa307 commented 2 weeks ago

/label tide/merge-method-squash

gauravkghildiyal commented 1 week ago

Also, is this TODO something that we plan on fixing independently? I guess as long as the MSC flags are disabled, this shouldn't cause any problems but please do confirm. Thanks!

sawsa307 commented 1 week ago

Also, is this TODO something that we plan on fixing independently? I guess as long as the MSC flags are disabled, this shouldn't cause any problems but please do confirm. Thanks!

Yes I'm planning to tackle those TODO in follow up PRs(like #2728), but if you would like, I can also include some of them in this PR as well.