Implement namespaced informer

kubernetes / ingress-gce

Ingress controller for Google Cloud

Apache License 2.0

1.27k stars 301 forks source link

Implement namespaced informer #2703

Closed panslava closed 3 weeks ago

panslava commented 3 weeks ago

This informer satisfies interface of normal informer
This informer will react to events happening only for objects in specific namespace
This informer will List only objects in specific namespace

Not used yet, will be used in next PRs

/assign @gauravkghildiyal @swetharepakula

panslava commented 3 weeks ago

For reviewers -- I am open for suggestions of folder/file namings and structure, but that's the best I came up myself at the moment, I will keep multiproject stuff inside folder pkg/multiproject and split it by folder-packages inside

panslava commented 3 weeks ago

Ready for re-review @gauravkghildiyal , thank you for the comments!

panslava commented 3 weeks ago

@gauravkghildiyal that's a very good thinking, thanks for digging into kubernetes code, I agree it will be better (and code actually cleaner) if we merge store and indexer into the same struct, I did that, and removed namespacedstore completely, now indexer and store is implemented inside namespacedcache struct and file

Ready for re-review

gauravkghildiyal commented 3 weeks ago

Great, thanks!

/lgtm

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, panslava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/ingress-gce/blob/master/OWNERS)~~ [gauravkghildiyal,panslava] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment