search

kubernetes / ingress-gce

Ingress controller for Google Cloud
Apache License 2.0
1.27k stars 301 forks source link

Use Object Label to identify Project, instead of Namespace, rename the flag #2720

Closed panslava closed 2 weeks ago

panslava commented 2 weeks ago

/assign @gauravkghildiyal

gauravkghildiyal commented 2 weeks ago

/lgtm

k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, panslava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/ingress-gce/blob/master/OWNERS)~~ [gauravkghildiyal,panslava] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment