search

kubernetes / ingress-gce

Ingress controller for Google Cloud
Apache License 2.0
1.27k stars 301 forks source link

Extend retrieve current NEG endpoints to also look for NEGs in non-default subnets. #2731

Open sawsa307 opened 1 week ago

sawsa307 commented 1 week ago

/assign @gauravkghildiyal

gauravkghildiyal commented 1 week ago

Thanks!

Haven't checked the tests, but besides those, this one is looking relatively straightforward.

k8s-ci-robot commented 2 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sawsa307 Once this PR has been reviewed and has the lgtm label, please ask for approval from gauravkghildiyal. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/ingress-gce/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment