search

kubernetes / ingress-gce

Ingress controller for Google Cloud
Apache License 2.0
1.27k stars 301 forks source link

Move Equal, EqualIPv6 and Patchable into forwardingrules pkg #2737

Closed TortillaZHawaii closed 2 days ago

TortillaZHawaii commented 3 days ago

Mixed protocol feature requires those functions. To prevent package dependency cycles these methods are moved to pkg/forwardingrules.

k8s-ci-robot commented 3 days ago

Hi @TortillaZHawaii. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
TortillaZHawaii commented 3 days ago

/assign @mmamczur

TortillaZHawaii commented 2 days ago

/lint

mmamczur commented 2 days ago

/ok-to-test

mmamczur commented 2 days ago

/lgtm

k8s-ci-robot commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmamczur, TortillaZHawaii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/ingress-gce/blob/master/OWNERS)~~ [mmamczur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment