Closed lexfrei closed 4 weeks ago
This issue is currently awaiting triage.
If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted
label and provide further guidance.
The triage/accepted
label can be added by org members by writing /triage accepted
in a comment.
/remove-kind bug Do you mean this needs to change https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/changelog/Changelog-4.8.3.md
We could add a link to the controller release notes in the helm release notes,
The controller and helm charts have a separate release cadence.
We always update the support table that maps controller to chart https://github.com/kubernetes/ingress-nginx#supported-versions-table
/assign
Let me explain.
I guess all @lexfrei wants is something adding the content of the generated changelog file to be included in the Helm chart releases.
This mage step generates the changelog: https://github.com/kubernetes/ingress-nginx/blob/main/magefiles/steps/release.go
This action generates the helm-chart-*
releases: https://github.com/kubernetes/ingress-nginx/blob/main/.github/workflows/helm.yaml
btw: I also have a PR open for improving the way those changelogs are getting named & templated: https://github.com/kubernetes/ingress-nginx/pull/10622
I could try to improve the action so it also contains the changelog's content.
/retitle Chart: Changelogs not contained in GitHub releases.
Any news on this?
Looks like, the chart should generate and post chengelog somewhere.
Currently, there are no changelogs posted in releases for chart.
We really need to know about breaking changes, like https://github.com/kubernetes/ingress-nginx/pull/10393
Also, this breaking change is not mentioned in chart's changelog and it's a problem. As chart user, I can't expect so big change without a line in changelog.