kubernetes / ingress-nginx

Ingress NGINX Controller for Kubernetes
https://kubernetes.github.io/ingress-nginx/
Apache License 2.0
17.33k stars 8.22k forks source link

Fetch node labels only when enable-topology-aware-routing is true #10664

Open gramulka opened 10 months ago

gramulka commented 10 months ago

What happened:

We're not using enable-topology-aware-routing flag, and cluster access is disabled for us, and on startup nginx gives us the following warning: "W1121 08:47:25.273958 7 main.go:125] Unable to get NODE information: nodes "....internal" is forbidden: User "..." cannot get resource "nodes" in API group "" at the cluster scope"

What you expected to happen:

As enable-topology-aware-routing is disabled by default, we're expecting that nginx wouldn't try to fetch node labels.

NGINX Ingress controller version (exec into the pod and run nginx-ingress-controller --version.):

nginx controller version: 1.8.4

Kubernetes version (use kubectl version): 1.26

Environment:

How to reproduce this issue:

Anything else we need to know:

k8s-ci-robot commented 10 months ago

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.