kubernetes / ingress-nginx

Ingress-NGINX Controller for Kubernetes
https://kubernetes.github.io/ingress-nginx/
Apache License 2.0
17.26k stars 8.2k forks source link

ginkgo bump requirement reported in CI e2e #11466

Closed longwuyuan closed 3 months ago

longwuyuan commented 3 months ago

What happened:

go: downloading github.com/onsi/ginkgo/v2 v2.19.0 go: downloading github.com/stretchr/testify v1.9.0


- I tried to run kind e2e test locally like thus

FOCUS="backend-protocol" make kind-e2e-test



- Its possible that this is yet another repeat event where dependabot PR bumped ginkgo from v2.17.1 to v2.19.0 but the hardcoded pinned locations in the project were not changed to sync with  the dependabot PR change

- The above suspicion is kinda more likely because its visible in the screenshot below
![image](https://github.com/kubernetes/ingress-nginx/assets/5085914/8c6d5f0e-69f5-43ce-9faa-7fa1adf61d47)

- There are plans to remove that test-runner image which will remove at least some of this pinned versions but that is work-in-progress (also  owned by me)

- So this issue is to track current status and record opinions or take actions (if any)

/triage accepted

@Gacko  please check and advise if I can do anything
longwuyuan commented 3 months ago

/assign @Gacko

Gacko commented 3 months ago

Ah, sorry! I think I lgtm'd that Dependabot PR recently. Gonna create a follow up to align it everywhere. Thanks for pointing that out! 🙂

Gacko commented 3 months ago

Here's the PR. Unfortunately you cannot lgtm it, so I'll post it to #ingress-nginx-dev and see if someone else wants to. 😬