search

kubernetes / ingress-nginx

Ingress-NGINX Controller for Kubernetes
https://kubernetes.github.io/ingress-nginx/
Apache License 2.0
16.95k stars 8.14k forks source link

Bump NGINX_BASE to new tag or revert TAG #11514

Open ipaqsa opened 1 week ago

ipaqsa commented 1 week ago

I recently have bumped nginx 1.25 image to 1.25.5(https://github.com/kubernetes/ingress-nginx/pull/11470), and updated the image TAG, and i am still not sure that it was the right. But if we merged this PR, i think we should bump NGINX_BASE image(which is used for tests) to a new TAG or we need to revert TAG. I didn't do it because I don't know the process.

And there is another problem that build was not successful(https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-ingress-nginx-push-images/1803148085384187904) and v0.0.7 is not present in the registry. This affects this PR https://github.com/kubernetes/ingress-nginx/pull/10984

k8s-ci-robot commented 1 week ago

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
strongjz commented 4 days ago

GCP Cloud build has to pass so it's in the staging registry and then we promote in the k8s.io to production, then we can put in a PR to update in our NGINX_BASE image.

https://github.com/kubernetes/ingress-nginx/blob/main/MANUAL_RELEASE.md#2-if-applicable-build-other-images

ipaqsa commented 4 days ago

@strongjz Thanks, i got it!