hpa stopped working with keda disabled

[hydrapolic]

What happened:

After upgrading the controller from 1.10.1 -> 1.11.1 and the chart from 4.10.0 -> 4.11.1, hpa stopped working.

This hpa config worked before:

    {
      type  = "string"
      name  = "controller.autoscaling.enabled"
      value = "true"
    },
    {
      type  = "auto"
      name  = "controller.autoscaling.minReplicas"
      value = 2
    },
    {
      type  = "auto"
      name  = "controller.autoscaling.maxReplicas"
      value = 4
    },
    {
      type  = "auto"
      name  = "controller.autoscaling.targetCPUUtilizationPercentage"
      value = 90
    },
    {
      type  = "auto"
      name  = "controller.autoscaling.targetMemoryUtilizationPercentage"
      value = 90
    }

Now this error was shown then trying to update the controller/chart:

14:34:44  module.ingress_nginx.helm_release.ingress_nginx[0]: Modifying... [id=ingress-nginx]
14:34:47  ╷
14:34:47  │ Error: template: ingress-nginx/templates/controller-deployment.yaml:22:9: executing "ingress-nginx/templates/controller-deployment.yaml" at <eq .Values.controller.autoscaling.enabled .Values.controller.keda.enabled>: error calling eq: incompatible types for comparison

After adding:

    {
      type  = "string"
      name  = "controller.keda.enabled"
      value = "false"
    },

It applies the config, however HPA is disabled.

What you expected to happen:

NGINX Ingress controller version (exec into the pod and run nginx-ingress-controller --version.):

-------------------------------------------------------------------------------
NGINX Ingress controller
  Release:       v1.11.1
  Build:         7c44f992012555ff7f4e47c08d7c542ca9b4b1f7
  Repository:    https://github.com/kubernetes/ingress-nginx
  nginx version: nginx/1.25.5

-------------------------------------------------------------------------------

Kubernetes version (use kubectl version):

Client Version: v1.29.6 Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3 Server Version: v1.29.6-gke.1038001

Environment:

• Cloud provider or hardware configuration: GCP

• OS (e.g. from /etc/os-release): Container-Optimized OS with containerd (cos_containerd)

• Kernel (e.g. uname -a):

• Install tools:

  • Please mention how/where was the cluster created like kubeadm/kops/minikube/kind etc.

• Basic cluster related info:

  • kubectl version
  • kubectl get nodes -o wide

• How was the ingress-nginx-controller installed: Terraform with helm chart (helm_release resource)

  • If helm was used then please show output of helm ls -A | grep -i ingress
  • If helm was used then please show output of helm -n <ingresscontrollernamespace> get values <helmreleasename>
  • If helm was not used, then copy/paste the complete precise command used to install the controller, along with the flags and options used
  • if you have more than one instance of the ingress-nginx-controller installed in the same cluster, please provide details for all the instances

• Current State of the controller:

  Name:         nginx
  Labels:       app.kubernetes.io/component=controller
            app.kubernetes.io/instance=ingress-nginx
            app.kubernetes.io/managed-by=Helm
            app.kubernetes.io/name=ingress-nginx
            app.kubernetes.io/part-of=ingress-nginx
            app.kubernetes.io/version=1.11.1
            helm.sh/chart=ingress-nginx-4.11.1
  Annotations:  meta.helm.sh/release-name: ingress-nginx
            meta.helm.sh/release-namespace: default
  Controller:   k8s.io/ingress-nginx
  Events:       <none>

  • kubectl describe ingressclasses
  • kubectl -n <ingresscontrollernamespace> get all -A -o wide
  • kubectl -n <ingresscontrollernamespace> describe po <ingresscontrollerpodname>
  • kubectl -n <ingresscontrollernamespace> describe svc <ingresscontrollerservicename>

• Current state of ingress object, if applicable:

  • kubectl -n <appnamespace> get all,ing -o wide
  • kubectl -n <appnamespace> describe ing <ingressname>
  • If applicable, then, your complete and exact curl/grpcurl command (redacted if required) and the reponse to the curl/grpcurl command with the -v flag

• Others:

  • Any other related information like ;
  • copy/paste of the snippet (if applicable)
  • kubectl describe ... of any custom configmap(s) created and in use
  • Any other related information that may help

How to reproduce this issue:

Anything else we need to know:

Maybe related to https://github.com/kubernetes/ingress-nginx/pull/11110

[k8s-ci-robot]

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[longwuyuan]

can you show helm -n ingress-nginx get values ingress-nginx

[longwuyuan]

@Gacko if I stay on v1.11 and go from default install to enabling hpa, then no problems so looks like a upgrade only scene.

[Gacko]

enabled is not a string, it's a boolean. Please use a boolean. We also have unit tests for that, so I doubt it's broke.

[longwuyuan]

/remove-kind bug

I can NOT reproduce error while having installed v1.11.1 without autoscaling enabled and then making a change via helm to enable autoscaling.

So the config itself is not a problem.

/kind support

Like @Gacko mentioned, it could be the config value not being boolean to begin with.

@hydrapolic please provide details around the issue and state to base some comments on

/triage needs-information

[hydrapolic]

Thank you for the help, it really was the problem with string vs boolean in autoscaling.enabled. It worked before, but seems like the changes made it problematic now.

This now works fine:

helm get values ingress-nginx
USER-SUPPLIED VALUES:
controller:
  autoscaling:
    enabled: true
    maxReplicas: 4
    minReplicas: 2
    targetCPUUtilizationPercentage: 90
    targetMemoryUtilizationPercentage: 90

In terraform:

{
  type  = "string"
  name  = "controller.autoscaling.enabled"
  value = "true"
}

->

{
  type  = "auto"
  name  = "controller.autoscaling.enabled"
  value = true
}

And no keda config is needed at all.

Thanks @longwuyuan and @Gacko