kubernetes / ingress-nginx

Ingress NGINX Controller for Kubernetes
https://kubernetes.github.io/ingress-nginx/
Apache License 2.0
17.53k stars 8.26k forks source link

Support another Ip2info provider #12315

Open tanoggy opened 1 week ago

tanoggy commented 1 week ago

Support another in2info provider Can I develop a feature Support https://ipinfo.io/products/free-ip-database

k8s-ci-robot commented 1 week ago

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
longwuyuan commented 1 week ago

We are trying to deprecate even geoip2 https://github.com/kubernetes/ingress-nginx/issues/11669

tanoggy commented 1 week ago

We are trying to deprecate even geoip2 #11669

https://github.com/kubernetes/ingress-nginx/issues/11669 is close, can I develop this feature

longwuyuan commented 1 week ago

It will be nice to have it. But we don't want to maintain & support new features. The problem is there are no resources to support/maintain new features. And also many of the features that are super useful are leading to security/stability issues, if they are not part of the core Ingress-API spec.

longwuyuan commented 1 week ago

@tanoggy I saw just now that the free datatype for ipinfo.io has at least this much

Free
{
  "ip": "211.197.11.0",
  "city": "Kyosai",
  "region": "Gyeongsangnam-do",
  "country": "KR",
  "loc": "34.8503,128.5886",
  "org": "AS4766 Korea Telecom",
  "postal": "53285",
  "timezone": "Asia/Seoul",
  "tags": []
}

You can join the community meetings and ask if there is interest in a PR for this https://github.com/kubernetes/community/tree/master/sig-network

abdullahdevrel commented 6 days ago

Thanks @tanoggy I work for IPinfo, and I really appreciate the feature request!

For context, our free IP database comes in various formats, with the IP to Country ASN database being one of the most popular. It includes features such as:

Database schema

Field Name Example Data Type Description
start_ip 1.0.16.0 TEXT Starting IP address of an IP address range
end_ip 1.0.31.255 TEXT Ending IP address of an IP address range
country JP TEXT ISO 3166 country code of the location
country_name Japan TEXT Name of the country
continent AS TEXT Continent code of the country
continent_name Asia TEXT Name of the continent
asn AS2519 TEXT Autonomous System Number
as_name ARTERIA Networks Corporation TEXT Name of the AS (Autonomous System) organization
as_domain arteria-net.com TEXT Official domain or website of the AS organization

Documentation: https://ipinfo.io/developers/ip-to-country-asn-database