Fix Opentelemetry version and compilation

matthias-haase commented 1 week ago

What this PR does / why we need it:

Bump Opentelemetry version to fix span sending, and fix Opentelemetry compilation

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] CVE Report (Scanner found CVE and adding report)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation only

Which issue/s this PR fixes

fixes #12210

How Has This Been Tested?

Tested on Azure Kubernetes with datadog pods sending traces and check on datadog.com Dashboard.

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I've read the CONTRIBUTION guide
[ ] I have added unit and/or e2e tests to cover my changes.
[ ] All new and existing tests passed.

linux-foundation-easycla[bot] commented 1 week ago

:x: login: @tsimonitoring / The commit (69a416b84de0ab9b840f1088067d1c2ea4c64f4d). This user is authorized, but they must confirm their affiliation with their company. Start the authorization process by clicking here, click \"Corporate\", select the appropriate company from the list, then confirm your affiliation on the page that appears. For further assistance with EasyCLA, please submit a support request ticket.

k8s-ci-robot commented 1 week ago

Welcome @matthias-haase!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 week ago

Hi @matthias-haase. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: matthias-haase Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes/ingress-nginx/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

netlify[bot] commented 1 week ago

Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
Latest commit	69a416b84de0ab9b840f1088067d1c2ea4c64f4d
Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/6737318e0c06a00008d3e31a

rikatz commented 1 week ago

@matthias-haase do you mind signing the CLA?

Also please follow the PR template here, refer to the original issue with all the descriptions but on the PR just mention you are fixing Opentelemtry compilation and Version.

Thanks!

/ok-to-test /triage accepted /priority important-soon /kind bug /cc @esigo /assign @esigo

rikatz commented 1 week ago

(I will actually edit the PR and fix its description, please just be sure to follow it next time)

Gacko commented 6 days ago

/close

Duplicate of https://github.com/kubernetes/ingress-nginx/pull/12371.

k8s-ci-robot commented 6 days ago

@Gacko: Closed this PR.

In response to [this](https://github.com/kubernetes/ingress-nginx/pull/12370#issuecomment-2479909982): >/close > >Duplicate of https://github.com/kubernetes/ingress-nginx/pull/12371. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

kubernetes / ingress-nginx