kubernetes / ingress-nginx

Ingress-NGINX Controller for Kubernetes

https://kubernetes.github.io/ingress-nginx/

Apache License 2.0

17.26k stars 8.21k forks source link

krew plugin need update #7627

Closed cnscud closed 2 years ago

cnscud commented 3 years ago

It is 0.31, not the latest version.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

tao12345666333 commented 2 years ago

/assign let me update it.

tao12345666333 commented 2 years ago

/assign

tao12345666333 commented 2 years ago

/remove-lifecycle stale

tao12345666333 commented 2 years ago

In fact, our new version (v1.x) did not release a separate binary file at the time of release.

According to krew's documentation, we can automate it. https://krew.sigs.k8s.io/docs/developer-guide/release/automating-updates/

I want to discuss whether we need to maintain it.
/cc @rikatz @strongjz

rikatz commented 2 years ago

I'm a +1 for this! I did that with a pet project myself, using goreleaser and a gh action to update the plugin.

tao12345666333 commented 2 years ago

In fact, our new version (v1.x) did not release a separate binary file at the time of release.

@rikatz Then we need to upload the binary file when we release.

rikatz commented 2 years ago

Yup. Go releaser can do that :)

tao12345666333 commented 2 years ago

👌 I will handle it

tao12345666333 commented 2 years ago

/triage accepted

tao12345666333 commented 2 years ago

@rikatz I found that we already have a job, but it is disabled https://github.com/kubernetes/ingress-nginx/blob/main/.github/workflows/release.txt

xref: https://github.com/kubernetes/ingress-nginx/pull/5436

tao12345666333 commented 2 years ago

I will try to enable it and use it with https://github.com/rajatjindal/krew-release-bot

ElvinEfendi commented 2 years ago

@tao12345666333 is there any blocker here?

tao12345666333 commented 2 years ago

Not currently, I am testing it, and I can submit a PR within this week to complete it

tao12345666333 commented 2 years ago

8194 is another case.

I'm sorry for the delay, but I should be able to make time for it this week.

jsoref commented 2 years ago

It was disabled by @aledbf in #5434 with no explanation.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

jsoref commented 2 years ago

/remove-lifecycle stale

Volatus commented 2 years ago

/assign