Migrate away from google.com gcp project kubernetes-node-e2e-images

spiffxp commented 3 years ago

Part of umbrella issue to migrate away from google.com gcp projects: https://github.com/kubernetes/k8s.io/issues/1469

Part of umbrella to migrate kubernetes e2e test images/registries to community-owned infrastructure: https://github.com/kubernetes/k8s.io/issues/1458

This project is referenced in kubernetes/kubernetes as a default project (ref: https://cs.k8s.io/?q=kubernetes-node-e2e-images&i=nope&files=&repos=)

However, it may not actually be in use?

$ gcloud container images list --repository=gcr.io/kubernetes-node-e2e-images
Listed 0 items.
$ gsutil ls -p kubernetes-node-e2e-images
$

This covers:

determining if the project is used for anything
if so, identify whether an existing or new CNCF-owned gcp project should be used instead
it not, remove references to this project

/wg k8s-infra /sig testing /sig release /area release-eng /sig node

spiffxp commented 3 years ago

/milestone v1.21

BobyMCbobs commented 3 years ago

According to https://cs.k8s.io/?q=kubernetes-node-e2e-images&i=nope&files=&excludeFiles=&repos=, it appears that this project may not have been used since around 2016.

ameukam commented 3 years ago

/milestone v1.22

ameukam commented 3 years ago

@spiffxp This project may be used for compute images. Can you check :

gcloud compute images list --project="kubernetes-node-e2e-images" | grep "e2e-node"

spiffxp commented 2 years ago

@ameukam There are very much some images here, and I see it listed in docs and as a default, but I can't tell that it's actually what is used for node-e2e tests. These all seem pretty old to me.

$ gcloud compute images list --project="kubernetes-node-e2e-images" | grep "e2e-node"
e2e-node-containervm-v20160321-image                  kubernetes-node-e2e-images                                                READY
e2e-node-containervm-v20160604-image                  kubernetes-node-e2e-images                                                READY
e2e-node-containervm-v20161208-image                  kubernetes-node-e2e-images                                                READY
e2e-node-coreos-alpha-1068-20160707-image             kubernetes-node-e2e-images                                                READY
e2e-node-coreos-stable20160218-image                  kubernetes-node-e2e-images                                                READY
e2e-node-coreos-stable20160531-image                  kubernetes-node-e2e-images                                                READY
e2e-node-coreos-stable20160622-image                  kubernetes-node-e2e-images                                                READY
e2e-node-ubuntu-trusty-docker10-image                 kubernetes-node-e2e-images                                                READY
e2e-node-ubuntu-trusty-docker10-v1-image              kubernetes-node-e2e-images                                                READY
e2e-node-ubuntu-trusty-docker10-v2-image              kubernetes-node-e2e-images                                                READY
e2e-node-ubuntu-trusty-docker12-v1-image              kubernetes-node-e2e-images                                                READY
e2e-node-ubuntu-trusty-docker12-v2-image              kubernetes-node-e2e-images                                                READY
e2e-node-ubuntu-trusty-docker8-image                  kubernetes-node-e2e-images                                                READY
e2e-node-ubuntu-trusty-docker9-image                  kubernetes-node-e2e-images                                                READY
e2e-node-ubuntu-trusty-docker9-v1-image               kubernetes-node-e2e-images                                                READY

spiffxp commented 2 years ago

/remove-priority important-soon /priority important-longterm /milestone v1.23 I don't see this eating a lot of project resources but that makes it even lower hanging fruit to remove. Let's get references to this out of source once the release cycle opens back up

spiffxp commented 2 years ago

/remove-priority important-longterm /priority important-soon

endocrimes commented 2 years ago

/cc

spiffxp commented 2 years ago

/milestone v1.24

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ameukam commented 2 years ago

/remove-lifecycle stale

ameukam commented 2 years ago

/milestone clear

SergeyKanzhelev commented 2 years ago

/assign @endocrimes

to check that we indeed doesn't use any of those

ehashman commented 2 years ago

I just did a code search for the images. None of them are used. The only one that comes up in search is https://cs.k8s.io/?q=e2e-node-containervm&i=nope&files=&excludeFiles=&repos= and it's from an old vendor/persists in an example in some of the e2e node developer documentation. @endocrimes you might want to update that.

I think it's fine to remove the project at this time.

BenTheElder commented 2 years ago

I dont even see a registry under gcr.io/kubernetes-node-e2e-images ?

ameukam commented 2 years ago

I dont even see a registry under gcr.io/kubernetes-node-e2e-images ?

@BenTheElder This project contains disk images for Compute instances. See https://github.com/kubernetes/k8s.io/issues/1527#issuecomment-887193027.

@endocrimes I still see references of this project: https://cs.k8s.io/?q=kubernetes-node-e2e-images&i=nope&files=&excludeFiles=&repos= Can we drop https://github.com/kubernetes/kubernetes/blob/f173d01c011c3574dea73a6fa3e20b0ab94531bb/hack/make-rules/test-e2e-node.sh#L92 before we remove this project ?

BenTheElder commented 2 years ago

ah, yes I see images in https://console.cloud.google.com/compute/images?tab=images&project=kubernetes-node-e2e-images

endocrimes commented 2 years ago

@ameukam sure I'll drop it in a bit

endocrimes commented 2 years ago

actually gonna drop the list images stuff all together, it's not useful any mroe

ameukam commented 2 years ago

/milestone v1.25

ameukam commented 2 years ago

/lifecycle rotten

endocrimes commented 2 years ago

https://github.com/kubernetes/kubernetes/pull/109606 merged - should be safe to remove the project whenever now

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen
Mark this issue or PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 2 years ago

@k8s-triage-robot: Closing this issue.

In response to [this](https://github.com/kubernetes/k8s.io/issues/1527#issuecomment-1145872872): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

endocrimes commented 2 years ago

/reopen

I think we just need Google infra folks to remove the project now?

k8s-ci-robot commented 2 years ago

@endocrimes: Reopened this issue.

In response to [this](https://github.com/kubernetes/k8s.io/issues/1527#issuecomment-1145921194): >/reopen > >I think we just need Google infra folks to remove the project now? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

BenTheElder commented 2 years ago

I do appear to have access to project owner from this one via a group, but I'm extra hesistant to delete projects I'm not involved with directly.

I think my preference would be to soft disable first, but it looks like we've already deleted all VM images in the project?

ameukam commented 2 years ago

I think my preference would be to soft disable first, but it looks like we've already deleted all VM images in the project?

The VM images are now unused since we migrate the tests to the public GCP compute images. I'll suggest to disable to the Compute Engine API if we are hesitant to delete this project.

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen
Mark this issue or PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 1 year ago

@k8s-triage-robot: Closing this issue.

In response to [this](https://github.com/kubernetes/k8s.io/issues/1527#issuecomment-1179262714): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

endocrimes commented 1 year ago

/reopen /lifecycle frozen

I think @BenTheElder is on PTO, but hopefully we can finish this when he's back

k8s-ci-robot commented 1 year ago

@endocrimes: Reopened this issue.

In response to [this](https://github.com/kubernetes/k8s.io/issues/1527#issuecomment-1179412475): >/reopen >/lifecycle frozen > >I think @BenTheElder is on PTO, but hopefully we can finish this when he's back Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

endocrimes commented 1 year ago

/assign @BenTheElder

ameukam commented 1 year ago

/milestone clear

BenTheElder commented 1 year ago

I don't have (IAM) permission to do anything to this project. /assign @spiffxp

kubernetes / k8s.io

Migrate away from google.com gcp project kubernetes-node-e2e-images #1527