kubernetes / k8s.io

Code and configuration to manage Kubernetes project infrastructure, including various *.k8s.io sites
https://git.k8s.io/community/sig-k8s-infra
Apache License 2.0
690 stars 782 forks source link

sig-scheduling: add group for CI failures #6876

Closed pohly closed 3 weeks ago

pohly commented 3 weeks ago

This will be used initially to receive testgrid alerts for the scheduler_perf job. See https://github.com/kubernetes/test-infra/pull/32707#discussion_r1628157415

/cc @sanposhiho @Huang-Wei @alculquicondor @kerthcet @ahg-g

pohly commented 3 weeks ago

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/k8s.io/6876/pull-k8sio-groups-test/1798978200462692352:

Could not load groups config: couldn't merge groups: cannot define group "sig-scheduling-alerts@kubernetes.io" in "sig-scheduling/groups.yaml"

Does anyone know what that is supposed to mean and how to fix it?

alculquicondor commented 3 weeks ago

Does anyone know what that is supposed to mean and how to fix it?

I don't know the point of this file, but you have to add it there too

https://github.com/kubernetes/k8s.io/blob/c7950bd36ee717d640413e2a636a2661596e91b7/groups/restrictions.yaml#L188

pohly commented 3 weeks ago

The restrictions.yaml is probably there to prevent that SIGs create new groups without asking for approval.

pohly commented 3 weeks ago

@alculquicondor: please take another look, the tests are passing.

alculquicondor commented 3 weeks ago

/lgtm /approve

pohly commented 3 weeks ago

/assign @dims

For approval.

dims commented 3 weeks ago

/approve

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, dims, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[groups/OWNERS](https://github.com/kubernetes/k8s.io/blob/main/groups/OWNERS)~~ [dims] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment