kubernetes / k8s.io

Code and configuration to manage Kubernetes project infrastructure, including various *.k8s.io sites
https://git.k8s.io/community/sig-k8s-infra
Apache License 2.0
690 stars 782 forks source link

GCP: ensure prow-build can has iam.serviceAccountUser role #6920

Closed pwschuurman closed 4 days ago

pwschuurman commented 4 days ago

Ensure the GCP SA prow-build can act as other service accounts. This is required for the GCP PDCSI tests to call the GCE instances.insert API, as VMs are created with the Compute Engine default service account.

The GCP PDCSI e2e test prowjobs have failed after migrating to prow-build serviceAccount e.g. https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_gcp-compute-persistent-disk-csi-driver/1764/pull-gcp-compute-persistent-disk-csi-driver-e2e/1805708508784496640

pwschuurman commented 4 days ago

/cc @BenTheElder /assign @ameukam

mattcary commented 4 days ago

/lgtm

BenTheElder commented 4 days ago

/hold

k8s-ci-robot commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[infra/gcp/bash/prow/OWNERS](https://github.com/kubernetes/k8s.io/blob/main/infra/gcp/bash/prow/OWNERS)~~ [BenTheElder] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
BenTheElder commented 4 days ago

/hold cancel

BenTheElder commented 4 days ago

I'm still running this, it will take some time to complete ...

BenTheElder commented 4 days ago

For some context: the main e2e pool has 160 projects, this script manages them sequentially and we're currently on k8s-infra-e2e-boskos-028, it will take a bit, but it should be ready by sometime today.

BenTheElder commented 4 days ago

It crashed on #147 with a connection timeout issue, not related to this PR but will take a bit longer to resume

BenTheElder commented 4 days ago

Running infra/gcp/bash/prow/ensure-e2e-projects.sh k8s-infra-e2e-boskos-1{47..60} to expedite

BenTheElder commented 4 days ago

This should be available for k8s-infra-e2e-boskos-001 .. k8s-infra-e2e-boskos-160 (so, all projects in the main e2e pool)

BenTheElder commented 4 days ago

This is applying to the other project pools currently (most recently k8s-infra-e2e-ingress-project)

BenTheElder commented 4 days ago

This is done. Applied to all e2e projects.