search

kubernetes / k8s.io

Code and configuration to manage Kubernetes project infrastructure, including various *.k8s.io sites
https://git.k8s.io/community/sig-k8s-infra
Apache License 2.0
718 stars 805 forks source link

Initial terraform scripts for azure cncf subscription #6925

Closed ritikaguptams closed 2 months ago

ritikaguptams commented 3 months ago

Adding scripts to create resources for Azure CNCF subscription.

k8s-ci-robot commented 3 months ago

Welcome @ritikaguptams!

It looks like this is your first PR to kubernetes/k8s.io 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/k8s.io has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 3 months ago

Hi @ritikaguptams. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jsturtevant commented 2 months ago

/ok-to-test

dtzar commented 2 months ago

@ameukam this should help to get things moving with Azure

mboersma commented 2 months ago

Adding this so the quota changes we made to the sub are documented somewhere.

To try to ensure the new account has sufficient quota to handle e2e, I looked at existing usage.

I compared the quotas for the existing cncf-upstream sub with those of this new one, and determined that networking was ok and that only certain Compute vCPUs types needed an increase, and only in these regions that CAPZ uses for testing: canadacentral, eastus, eastus2, northeurope, southcentralus, uksouth, westeurope, westus2, and westus3.

Specifically:

I was able to increase most of the quotas by making a request directly in the Azure Portal. But some in-demand regions and vCPU types are unavailable, so I submitted a support ticket for those and await a response. In particular:

Increases to these same limits in the other regions were successful, and that's the extent of the quota requests made thusfar.

mboersma commented 2 months ago

The image-builder project is also using the new subscription, and needs to accept a license agreement before it can build Flatcar linux images:

az vm image terms accept --publisher kinvolk --offer flatcar-container-linux-free --plan free
resource "azurerm_marketplace_agreement" "kinvolk-agreement" {
  publisher = "kinvolk"
  offer     = "flatcar-container-linux-free"
  plan      = "free"
}
k8s-ci-robot commented 2 months ago

@dtzar: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubernetes/k8s.io/pull/6925#pullrequestreview-2192274737): >Some suggestions to make it better, but don't want to block to move this forward. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jsturtevant commented 2 months ago

/lgtm We know have all of CAPZ jobs and many of the sig-windows jobs running with this infra. While there may be some additions or changes I think we are in good shape to merge and make separate PR's as we go.

/assign @upodroid

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtzar, mboersma, ritikaguptams, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[infra/azure/OWNERS](https://github.com/kubernetes/k8s.io/blob/main/infra/azure/OWNERS)~~ [upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment