search

kubernetes / k8s.io

Code and configuration to manage Kubernetes project infrastructure, including various *.k8s.io sites
https://git.k8s.io/community/sig-k8s-infra
Apache License 2.0
736 stars 823 forks source link

Fix GCS notification terraform. #7266

Closed michelle192837 closed 2 months ago

michelle192837 commented 2 months ago

Minor fixes to ensure terraform apply actually succeeds. (This is posthoc; the terraform has already been applied and was successful).

Ref https://github.com/kubernetes/test-infra/issues/33386

ameukam commented 2 months ago

/lgtm /approve

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[infra/gcp/terraform/OWNERS](https://github.com/kubernetes/k8s.io/blob/main/infra/gcp/terraform/OWNERS)~~ [ameukam] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment