search

kubernetes / k8s.io

Code and configuration to manage Kubernetes project infrastructure, including various *.k8s.io sites
https://git.k8s.io/community/sig-k8s-infra
Apache License 2.0
735 stars 823 forks source link

Update groups.yaml Release Notes shadow 1.32 #7291

Closed satyampsoni closed 2 months ago

satyampsoni commented 2 months ago

cc @fsmunoz @katcosgrove @gracenng

fsmunoz commented 2 months ago

@satyampsoni just took a look, @gracenng already covered it :) If you could push an update we can proceed, thanks!

satyampsoni commented 2 months ago

Oops! It seems like I accidentally copied without editing, but I’ve fixed it now, @gracenng. As for Edith, she’s the comms shadow, and I was just organizing things in alphabetical order as @fsmunoz suggested in the slack message. Please let me know if i am getting that wrong, I can make like it was earlier.

fsmunoz commented 2 months ago

@satyampsoni sorting alphabetically is a requirement, it fails without it.

@gracenng the Comms shadows are in through https://github.com/kubernetes/k8s.io/pull/7288 , went investigating because I thought it could still be an artefact of 1.31.

(xref: https://github.com/kubernetes/sig-release/issues/2603 )

fsmunoz commented 2 months ago

/lgtm

katcosgrove commented 2 months ago

/approve

katcosgrove commented 2 months ago

/assign @justaugustus

(I should be able to approve this myself, I'll go fix my own perms)

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, katcosgrove, satyampsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[groups/sig-release/OWNERS](https://github.com/kubernetes/k8s.io/blob/main/groups/sig-release/OWNERS)~~ [justaugustus] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment