[BUG] underscores in compose service name are not replaced with dashes in kubernetes Service metadata.name

jancespivo commented 3 months ago

Expected Behavior

kompose convert should replace underscores with dashes in kubernetes Service metadata.name when compose service name contains underscores

apiVersion: v1
kind: Service
metadata:
  labels:
    io.kompose.service: myservice-api
  name: myservice-api  # THIS IS OK
spec:
  ports:
    - name: "8000"
      port: 8000
      targetPort: 8000
  selector:
    io.kompose.service: myservice-api

Actual Behavior

It generates:

apiVersion: v1
kind: Service
metadata:
  labels:
    io.kompose.service: myservice-api
  name: myservice_api  # <-- THIS IS NOT VALID name
spec:
  ports:
    - name: "8000"
      port: 8000
      targetPort: 8000
  selector:
    io.kompose.service: myservice-api

metadata.name is not valid (it contains underscore instead of dash)

Steps To Reproduce

No response

Kompose Version

1.34.0

Docker-Compose file

No response

Anything else?

No response

k8s-triage-robot commented 1 week ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

jancespivo commented 6 days ago

/remove-lifecycle stale

kubernetes / kompose