search

kubernetes / kompose

Convert Compose to Kubernetes
http://kompose.io
Apache License 2.0
9.62k stars 760 forks source link

feature: support UID:GID in the user key #1929

Closed favonia closed 2 months ago

favonia commented 2 months ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

With this PR, Kompose can convert UID:GID to both RunAsUser and RunAsGroup. Previously, it cannot understand the :GID part.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

I modified the existing test case to check uid:gid. It does not check the simpler case uid. Also, one of the file does not seem to have existing tests (?).

linux-foundation-easycla[bot] commented 2 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 2 months ago

Welcome @favonia!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

favonia commented 2 months ago

Sorry for the compilation error. It's now fixed.

cdrage commented 2 months ago

Sorry for the compilation error. It's now fixed.

Apologize for the delay! I am on PTO. But I'll be happy to test this Tuesday :) pleases remind me if I don't haha! This is a great feature to finally add.

favonia commented 2 months ago

@cdrage ping

cdrage commented 2 months ago

Tested this out and it works great!

LGTM! Once this pasts tests, it'll merge.

Thanks for the awesome contribution!!

cdrage commented 2 months ago

/approve

cdrage commented 2 months ago

/lgtm

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, favonia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes/kompose/blob/main/OWNERS)~~ [cdrage] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment